Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_gast_with_compatibility.py due to the problem of gast in py3.8 #27433

Merged

Conversation

gfwm2013
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Describe

The 0.3.3 version of gast has a bug in python3.8 that would cause test_gast_with_compatibility to fail. But this problem doesn't affect the use of Paddle's related functions, therefore, the some tests in test_gast_with_compatibility would be disable in python3.8.

And this problem had been fixed and updated to version 0.4.1 of gast.

More information please refer to:
serge-sans-paille/gast#49

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@gfwm2013 gfwm2013 changed the title Fix test_gast_with_compatibility.py due to the problem of gast in pyt… Fix test_gast_with_compatibility.py due to the problem of gast in py3.8 Sep 21, 2020
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfwm2013 gfwm2013 merged commit 3fe176d into PaddlePaddle:develop Sep 21, 2020
gfwm2013 added a commit to gfwm2013/Paddle that referenced this pull request Sep 21, 2020
gfwm2013 added a commit that referenced this pull request Sep 22, 2020
* Fix test_gast_with_compatibility.py due to the problem of gast in python3.8 (#27433)

test=develop

* fix dll load bug on windows from python3.8 (#27324)

* Support python3.8 (#26850)

* Support python3.8

test=notest

* Replace the 'spawn' start method with 'fork' start method for multiprocessing, on MacOS with python>=3.8 (#27317)

* Replace the 'spawn' start method with 'fork' start method for multiprocessing, on MacOs when python>=3.8

test=develop

* Correct the error in decorator.py (#27409)

test=develop

Co-authored-by: Zhou Wei <52485244+zhouwei25@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants