Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python2 of windows don't need to install netifaces #27355

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented Sep 16, 2020

PR types

Bug fixes

PR changes

Others

Describe

python2 for windows not install netifaces, because windows don't have distribution now.

netifaces must use Visual C++ tools for python2 windows. It can be remove in python2 windows.
https://www.microsoft.com/en-us/download/details.aspx?id=44266

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhwesky2010 zhwesky2010 changed the title python2 for windows not install netifaces python2 of windows don't need to install netifaces Sep 17, 2020
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 7d7f0fa into PaddlePaddle:develop Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants