fix xmap_readers and refine flowers dataset #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wanghaoshuang
commented
Jun 28, 2017
wanghaoshuang
commented
- fix xmap_readers bug . fix 过一个pass就停止不动了，内存占用着，但是cpu和gpu都为0了，就一直不动了 #2619
- refine flowers dataset reader. fix There is a bug on paddle.v2.dataset.flowers #2487
qingqing01
reviewed
Jun 28, 2017
python/paddle/v2/dataset/flowers.py
Outdated
| @@ -63,22 +63,23 @@ def reader_creator(data_file, | |||
| setid_file, | |||
| dataset_name, | |||
| mapper=default_mapper, | |||
| buffered_size=1024): | |||
| buffered_size=1024, | |||
| useXmap=True): | |||
python/paddle/v2/dataset/flowers.py
Outdated
| @@ -151,15 +154,15 @@ def test(mapper=default_mapper, buffered_size=1024): | |||
| return reader_creator( | |||
| download(DATA_URL, 'flowers', DATA_MD5), | |||
| download(LABEL_URL, 'flowers', LABEL_MD5), | |||
| download(SETID_URL, 'flowers', SETID_MD5), 'tstid', mapper, | |||
| buffered_size) | |||
| download(SETID_URL, 'flowers', SETID_MD5), 'trnid', mapper, | |||
There was a problem hiding this comment.
It's better to add some comments why change the tstid to trnid.
dzhwinter
reviewed
Jun 28, 2017
| workers.append(worker) | ||
| for w in workers: | ||
| w.start() | ||
|
|
||
| def xreader(): |
There was a problem hiding this comment.
I'm unfamiliar with this part, should we put xreader in another file?
decorator function take reader as input, and an enhanced feature function is returned. xreader is more likely a 1 reader n writer pool.
There was a problem hiding this comment.
xmap_readers is like map_readers in decorator.py. They are truly decorators.
1. rename 'useXmap' to 'use_xmap' 2. add comments about exchanging train data and test data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.