NNPACKConvFunction #2625
Merged
NNPACKConvFunction #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
approved these changes
Jun 30, 2017
| @@ -0,0 +1,16 @@ | |||
| # Find the NNPACK library | |||
There was a problem hiding this comment.
It would be great if we add a /cmake/external/nnpack.cmake to download the source code and build nnpack, like what cmake/external/{glog,gflags,gtest}.cmake do. In this way, cc_{library,binary,test} defined in cmake/generic.cmake can also make use of NNPACK.
There was a problem hiding this comment.
But we don't have to complete it in this PR. I think an alternative is that we mark this in an issue and open subsequent PRs to fix it.
There was a problem hiding this comment.
Thank you for your comments. I also think automatically download the source code and compile it is better.
…ion calculation can be switched to the NNPACK function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.