-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ctc_beam_search_decoder design doc #2423
Conversation
doc/design/speech/README.MD
Outdated
</div> | ||
|
||
- The **Beam Search Decoder** for DS2 CTC-trained network follows the similar approach in \[[3](#references)\] with a modification for the ambiguous part, as shown in Figure 2. | ||
- An **external defined scorer** would be passed into the decoder to evaluate a candidate prefix during decoding whenever a space character appended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "defined"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
doc/design/speech/README.MD
Outdated
Figure 2. Algorithm for Beam Search Decoder. | ||
</div> | ||
|
||
- The **Beam Search Decoder** for DS2 CTC-trained network follows the similar approach in \[[3](#references)\] with a modification for the ambiguous part, as shown in Figure 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the ambiguous part and what is the modification? Could you please add more details?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
doc/design/speech/README.MD
Outdated
|
||
- The **Beam Search Decoder** for DS2 CTC-trained network follows the similar approach in \[[3](#references)\] with a modification for the ambiguous part, as shown in Figure 2. | ||
- An **external defined scorer** would be passed into the decoder to evaluate a candidate prefix during decoding whenever a space character appended. | ||
- Such scorer is a unified class, may consisting of language model, word count or any customed evaluators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- --> any other custom scorers.
- What do you mean by "a unified class"?
- Remove "may".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done and modified.
doc/design/speech/README.MD
Outdated
- The **Beam Search Decoder** for DS2 CTC-trained network follows the similar approach in \[[3](#references)\] with a modification for the ambiguous part, as shown in Figure 2. | ||
- An **external defined scorer** would be passed into the decoder to evaluate a candidate prefix during decoding whenever a space character appended. | ||
- Such scorer is a unified class, may consisting of language model, word count or any customed evaluators. | ||
- The **language model** is built from Task 5, with a parameter should be carefully tuned to achieve minimum WER/CER (c.f. Task 7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a parameters --> parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All done. Thx!
doc/design/speech/README.MD
Outdated
Figure 2. Algorithm for Beam Search Decoder. | ||
</div> | ||
|
||
- The **Beam Search Decoder** for DS2 CTC-trained network follows the similar approach in \[[3](#references)\] with a modification for the ambiguous part, as shown in Figure 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
doc/design/speech/README.MD
Outdated
</div> | ||
|
||
- The **Beam Search Decoder** for DS2 CTC-trained network follows the similar approach in \[[3](#references)\] with a modification for the ambiguous part, as shown in Figure 2. | ||
- An **external defined scorer** would be passed into the decoder to evaluate a candidate prefix during decoding whenever a space character appended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
doc/design/speech/README.MD
Outdated
|
||
- The **Beam Search Decoder** for DS2 CTC-trained network follows the similar approach in \[[3](#references)\] with a modification for the ambiguous part, as shown in Figure 2. | ||
- An **external defined scorer** would be passed into the decoder to evaluate a candidate prefix during decoding whenever a space character appended. | ||
- Such scorer is a unified class, may consisting of language model, word count or any customed evaluators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done and modified.
doc/design/speech/README.MD
Outdated
- The **Beam Search Decoder** for DS2 CTC-trained network follows the similar approach in \[[3](#references)\] with a modification for the ambiguous part, as shown in Figure 2. | ||
- An **external defined scorer** would be passed into the decoder to evaluate a candidate prefix during decoding whenever a space character appended. | ||
- Such scorer is a unified class, may consisting of language model, word count or any customed evaluators. | ||
- The **language model** is built from Task 5, with a parameter should be carefully tuned to achieve minimum WER/CER (c.f. Task 7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
update design doc for beam search with CTC and LM #2230