Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hardcoded cmake for cclient/test #2263

Merged
merged 2 commits into from
May 25, 2017
Merged

fix hardcoded cmake for cclient/test #2263

merged 2 commits into from
May 25, 2017

Conversation

helinwang
Copy link
Contributor

No description provided.

jacquesqiao
jacquesqiao reviewed May 25, 2017
View reviewed changes
paddle/go/cclient/CMakeLists.txt
# find cmake directory modules
get_filename_component(PARENT_DIR ${CMAKE_CURRENT_SOURCE_DIR} DIRECTORY)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这三行在一起是做啥

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacquesqiao 接下来的include(external/gtest)存在Paddle/cmake，所以这三行是把Padd/cmake加入cmake module find path.

@helinwang helinwang merged commit beec748 into PaddlePaddle:develop May 25, 2017
@helinwang helinwang deleted the cmake branch May 25, 2017 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helinwang @jacquesqiao