Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change optimizer to old paddle style #10921

Merged
merged 1 commit into from
May 25, 2018
Merged

Change optimizer to old paddle style #10921

merged 1 commit into from
May 25, 2018

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented May 25, 2018 •
edited
Loading

since paddle/optimizer is not a part of fluid code base, we should not use cc_test and cc_library function. cc_test will link fluid::memory module, which might not be compiled when just compile old paddle.

@reyoung reyoung requested a review from dzhwinter May 25, 2018 02:44
@reyoung reyoung force-pushed the feature/change_optimizer_tests branch from a772826 to c980e4c Compare May 25, 2018 07:10
dzhwinter
dzhwinter approved these changes May 25, 2018
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice move.

@reyoung reyoung merged commit dd428a0 into PaddlePaddle:develop May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhwinter dzhwinter dzhwinter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyoung @dzhwinter