Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add return_numpy back #10892

Merged
merged 2 commits into from
May 24, 2018
Merged

add return_numpy back #10892

merged 2 commits into from
May 24, 2018

Conversation

daming-lu
Copy link
Contributor

@daming-lu daming-lu commented May 24, 2018 •
edited by sidgoyal78
Loading

We need to add back return_numpy as we need to pass LoDTensor in the inference part for several examples including:

  • label_semantic_roles
  • recommender_system
    etc

sidgoyal78
sidgoyal78 reviewed May 24, 2018
View reviewed changes
Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, we will need to undo this as well?
https://github.com/PaddlePaddle/Paddle/pull/10741/files#diff-1166d6a224c6ac0d9bb10f367c312e22R102

@daming-lu daming-lu changed the title add upstream back add return_numpy back May 24, 2018
sidgoyal78
sidgoyal78 reviewed May 24, 2018
View reviewed changes
Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably add a description of why we need to revert?
(I edited the description)

@daming-lu daming-lu merged commit cc7b4b9 into PaddlePaddle:develop May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidgoyal78 sidgoyal78 sidgoyal78 approved these changes

@nickyfantasy nickyfantasy Awaiting requested review from nickyfantasy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daming-lu @sidgoyal78