Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify label_semantic_roles book example using new LoDTensor API #10886

Merged
merged 3 commits into from
May 25, 2018

Conversation

kexinzhao
Copy link
Contributor

Please check #10735 for why we are doing this.

To solve the issue above, we have merged a PR #10817 and now there is utility functions here to create LoDTensor.

So this means that we can simplify the book example code using the new API.
This PR tries to simplify the old label_semantic_roles book example.

@kexinzhao kexinzhao force-pushed the label_semantic_roles_lod branch 2 times, most recently from b4c66c2 to 8c1b2fc Compare May 23, 2018 23:10
@kexinzhao kexinzhao requested a review from sidgoyal78 May 24, 2018 03:41
Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. There are some changes to this PR, please see #10757

Can you please wait for that to get merged?

@kexinzhao
Copy link
Contributor Author

Sure

Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kexinzhao : Can you now modify? The code merged in is now working.

Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kexinzhao kexinzhao merged commit defbaff into PaddlePaddle:develop May 25, 2018
@kexinzhao kexinzhao deleted the label_semantic_roles_lod branch May 25, 2018 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants