Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix beam_search memory leak. #10185

Merged
merged 2 commits into from
Apr 25, 2018
Merged

Fix beam_search memory leak. #10185

merged 2 commits into from
Apr 25, 2018

Conversation

gongweibao
Copy link
Contributor

Fix part of #10155

jacquesqiao
jacquesqiao approved these changes Apr 25, 2018
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacquesqiao
Copy link
Member

jacquesqiao commented Apr 25, 2018 •
edited
Loading

It seems that this problem has no relationship with pserver?

@gongweibao
Copy link
Contributor Author

Yep.You are right.

@gongweibao gongweibao merged commit 2f53cd0 into PaddlePaddle:develop Apr 25, 2018
@gongweibao gongweibao deleted the fixmemleak2 branch April 25, 2018 07:05
@gongweibao gongweibao mentioned this pull request May 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

@panyx0718 panyx0718 Awaiting requested review from panyx0718

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gongweibao @jacquesqiao