Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paddle::framework::Tensor design issues #2929

Closed
wangkuiyi opened this issue Jul 17, 2017 · 0 comments · Fixed by #2964
Closed

paddle::framework::Tensor design issues #2929

wangkuiyi opened this issue Jul 17, 2017 · 0 comments · Fixed by #2964
Assignees

Comments

@wangkuiyi
Copy link
Collaborator

wangkuiyi commented Jul 17, 2017

  1. set_dims ==> Resize
  2. ShareDataFrom ==> ShareDataWith
  3. The following code snippet in ShareDataFrom
     std::vector<int> d = vectorize(dims_);
     int base = 1;
     for (size_t i = 1; i < d.size(); ++i) {
       base *= d[i];
     }
    looks like
    product(dims_);
  4. Document Tensor::offset_ as for supporting slicing.
  5. CheckDims ==> MustNotEmpty
  6. typename PType ==> typename Place
  7. Move class Deleter to paddle::memory.
  8. Remove T* raw_data() const.
  9. In SharedDataWith, replace
     holder_ = src.holder_;
     Resize(src.dims());
     start_ = src.start_;
    by
    *this = src;
  10. DDim dims() const ==> const DDim& dims() const
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants