Skip to content

Commit

Permalink
reduce p2p communication group,test=allcase (#53877)
Browse files Browse the repository at this point in the history
  • Loading branch information
LiYuRio authored May 22, 2023
1 parent 4dc6ce0 commit 649aae0
Show file tree
Hide file tree
Showing 4 changed files with 259 additions and 270 deletions.
35 changes: 0 additions & 35 deletions python/paddle/distributed/fleet/base/topology.py
Original file line number Diff line number Diff line change
Expand Up @@ -296,11 +296,6 @@ def _get_p2p_prev_rank(self):
def _set_p2p_group(self):
comm_lists = self._topo.get_comm_list('pipe')

self.send_next_group = None
self.send_prev_group = None
self.recv_next_group = None
self.recv_prev_group = None

for comm_ranks in comm_lists:
assert len(comm_ranks) == self._pp_degree
for idx, rank in enumerate(comm_ranks):
Expand All @@ -312,28 +307,6 @@ def _set_p2p_group(self):
self.next_rank = next_rank
self.prev_rank = prev_rank

next_group = paddle.distributed.new_group(
ranks=[curr_rank, next_rank]
)
if self.global_rank == curr_rank:
self.send_next_group = next_group
elif self.global_rank == next_rank:
self.recv_prev_group = next_group

prev_group = paddle.distributed.new_group(
ranks=[prev_rank, curr_rank]
)

if self.global_rank == curr_rank:
self.send_prev_group = prev_group
elif self.global_rank == prev_rank:
self.recv_next_group = prev_group

assert self.send_next_group is not None
assert self.send_prev_group is not None
assert self.recv_next_group is not None
assert self.recv_prev_group is not None

def topology(self):
return self._topo

Expand Down Expand Up @@ -385,14 +358,6 @@ def get_pipe_parallel_world_size(self):
def get_pipe_parallel_group(self):
return self._pp_comm_group

def get_p2p_groups(self):
return (
self.send_next_group,
self.send_prev_group,
self.recv_next_group,
self.recv_prev_group,
)

# sharding parallel message:
def _get_sharding_parallel_id(self):
return self._topo.get_coord(self.global_rank).sharding
Expand Down
Loading

0 comments on commit 649aae0

Please sign in to comment.