Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix segment ops #445

Merged
merged 2 commits into from
Aug 3, 2022
Merged

fix segment ops #445

merged 2 commits into from
Aug 3, 2022

Conversation

DesmonDay
Copy link
Contributor

@DesmonDay DesmonDay commented Aug 2, 2022 •
edited
Loading

  1. Fix bugs of segment ops.
  2. Delete unused code.

Yelrose
Yelrose requested changes Aug 2, 2022
View reviewed changes
pgl/math.py
@@ -35,14 +35,10 @@ def segment_pool(data, segment_ids, pool_type, name=None):
Segment Operator.
"""
pool_type = pool_type.upper()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

segment_pool 改成 if else，调用其他segment op

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Yelrose
Yelrose approved these changes Aug 3, 2022
View reviewed changes
Copy link
Collaborator

@Yelrose Yelrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yelrose Yelrose merged commit fa901df into PaddlePaddle:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yelrose Yelrose Yelrose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DesmonDay @Yelrose