A series of "clenups" #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not generally useful for everybody to export devos-lib. We can reintroduce a lib-exportin interface, once we conceputualize the private library sharing use case properly.
currently, there is no need for a recursiveUpdate, and since flake requires flattened trees, there might never be a good enough reason to use it at the expense of introducing a dependency on lib.
evalFlakeArgs is a private function to mkFlake, so there is no reason expense going over the top level namespace. Unfortunately, keeping boundaries around future devos-lib, this also means we cannot introduce a dependency on pkgs, and vie versa we cannot introduce a dependency on devos-lib lighthartedly (without a clear api) on pkgs. While this is genuinly useful, we ight need to find a cleaner and more organized way to implement this in the future.
we should consequently avoid variable redefintions while traversing through layers and interfaces. self is a flake native term and refers to a handle to the flake repo itself.
since lib is structured after upstream lib (lists, attrs, strings), and it is even conceived as lib.makeExtensible, it does not appear in line to namespace devos specific library additions: not only is the name `dev` little self explaining, we also have the `os` namespace, for if library functions are devos specific. The rest are just confenience functions which might as well ladn upstream one day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I atill have to find out wether jt's possible to take out the first commit on my cel, as discussed.