Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

hotfix for gcc/4.8.x #8

Closed
wants to merge 1 commit into from
Closed

hotfix for gcc/4.8.x #8

wants to merge 1 commit into from

Conversation

mhsieh
Copy link
Contributor

@mhsieh mhsieh commented Sep 20, 2016

@mhsieh
Copy link
Contributor Author

mhsieh commented Sep 20, 2016

Don't merge just yet, we have not validated this.

@nlhepler
Copy link
Contributor

https://github.com/nlohmann/json#supported-compilers

@mhsieh gcc/4.8.x is emphatically unsupported by the json author due to bugs in that version's implementation of the stdlib.

@pezmaster31
Copy link
Collaborator

That and this repo lives primarily in BB now, only mirrored here. We should place any PRs there, please.

@mhsieh
Copy link
Contributor Author

mhsieh commented Sep 20, 2016

I will remove the PR later, sorry about that.

@mhsieh
Copy link
Contributor Author

mhsieh commented Sep 20, 2016

@nlhepler - see that discussion thread, I think gcc/4.8.x might be still usable.

@mhsieh mhsieh closed this Sep 20, 2016
@nlhepler
Copy link
Contributor

@mhsieh it does seem that way, but at the end of the day he vetoed it: nlohmann/json#212 (comment)

@mhsieh
Copy link
Contributor Author

mhsieh commented Sep 20, 2016

This will break the travis ci. /me sad panda

@mhsieh mhsieh deleted the mhsieh-patch-1 branch September 20, 2016 21:15
pacbbbbot pushed a commit that referenced this pull request Sep 23, 2016
@armintoepfer
Merge pull request #8 in SAT/pbcopper from SAT-330 to master
0008415 
* commit '138b8eed0d1430f0beaa9bd53bc688a3d8baf077':
  Changed default for Task::IsDistributed() from false to true
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhsieh @nlhepler @pezmaster31