Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert SC1117 fixes that caused issues with miniwdl. #169

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

williamrowell
Copy link
Collaborator

  • In v2.0.5, backslashes in \t, \n, and other special characters were escaped to address SC1117. This introduced bugs that appeared at various parts of the analysis workflow depending on the backend. Reverting all of these changes until we have a better way of dealing with this.

@williamrowell williamrowell self-assigned this Nov 19, 2024
Copy link
Collaborator

@hkeward hkeward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamrowell williamrowell marked this pull request as ready for review November 19, 2024 21:09
@williamrowell williamrowell merged commit 8d9401f into main Nov 19, 2024
1 check passed
@williamrowell williamrowell deleted the fix/revert-SC1117 branch November 19, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants