Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jog parameter variables global #740

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

patryk3211
Copy link
Contributor

This PR makes the jog_distance and jog_feed globally accessible. My use case for this is to allow hardware buttons to use the same jogging parameters as set in the menu. Please let me know if this is fine or if these should stay static.

@Paciente8159
Copy link
Owner

I guess it's ok to allow using the built in jog callback

@Paciente8159
Copy link
Owner

I propose to rename the variables to g_system_menu_jog_distance and g_system_menu_jog_feed.
This way it will be more meaningful

@patryk3211
Copy link
Contributor Author

Done

@Paciente8159 Paciente8159 merged commit 0569d31 into Paciente8159:master Aug 23, 2024
19 checks passed
@patryk3211 patryk3211 deleted the system-menu-jog-params branch August 23, 2024 08:59
@patryk3211 patryk3211 restored the system-menu-jog-params branch August 23, 2024 11:23
@patryk3211 patryk3211 deleted the system-menu-jog-params branch August 23, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants