Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain MPC_COL_PREV_ANG #555

Merged
merged 3 commits into from
Aug 20, 2019
Merged

Explain MPC_COL_PREV_ANG #555

merged 3 commits into from
Aug 20, 2019

Conversation

hamishwillee
Copy link
Collaborator

This attempts to explain MPC_COL_PREV_ANG as introduced (and discussed in) PX4/PX4-Autopilot#12561

@jkflying and @baumanta you'll recognise the information and diagrams :-)

What has changed a bit here is that I believe that the angle MPC_COL_PREV_ANG is used for all movement, not just going backwards. So its tuning affects what happens all the time.

The other thing that I've tried to capture here is that when you go forward the distance calculated is based on the minimum distance from the whole set of included sensors. So if you're travelling along a wall and including a sensor, that is the distance, that gets included, not the empty space in front of you.

Anyway, please check I got it right. This was hard to understand and convey.

@hamishwillee hamishwillee merged commit 2874a2b into PX4:master Aug 20, 2019
@hamishwillee
Copy link
Collaborator Author

Thanks for that last clarifications @baumanta - that made it clear. I have done a further update to tidy and capture this and merged. I think this is all good now. Thanks also @jkflying .

@hamishwillee hamishwillee deleted the collision_angle branch August 20, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants