-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework filter tuning, add dynamic notch filters #3467
Conversation
julianoes
commented
Nov 20, 2024
- Expand the filters with sub-headings.
- Extend one static notch to two.
- Add dynamic notch filters.
- Expand the filters with sub-headings. - Extend one static notch to two. - Add dynamic notch filters.
en/config_mc/filter_tuning.md
Outdated
|
||
#### Dynamic Notch Filters | ||
|
||
Dynamic notch filters use ESC RPM feedback and/or the onboard FFT analysis to track the rotor blade pass frequency and its harmonics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The static notch filter appears to serve the same purpose - filter blade frequency and its first harmonic (vs dynamic multiple harmonics).
- So when would you use one or the other?
- The example in Daniels' original PR filtered crap from props with slight damage - I presume that results in more noise and harmonics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose the dynamic one is generally better but only possible when you have ESC feedback. Not sure about the FFT one?
@dagar when would you use the FFT instead of the static notch filter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we merge and you chase him for this answer offline? My concern is that he will be too busy to respond, and we end up merging this in 2 years, no better or worse off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me ping @bresch as well, he might know and answer quicker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FFT is to track a moving vibration peak (e.g.; the blade-pass frequency when ESC telemetry is not available). The static notch is usually to cover a structural mode of the airframe.
I would say that you either use the ESC feedback or the FFT to move the dynamic notches, but you can use a static notch in addition to the dynamic ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks excellent. Just a couple of minor questions
Thanks for the review @hamishwillee! |
Co-authored-by: Mathieu Bresciani <brescianimathieu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @julianoes and @bresch
No flaws found |