Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Land detector docs sync #2233

Merged
merged 9 commits into from
Jan 10, 2023
Merged

Land detector docs sync #2233

merged 9 commits into from
Jan 10, 2023

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented Dec 30, 2022

Notable PX4 PRs with land detector changes incorporated into the docs hereby:
PX4/PX4-Autopilot#20425
PX4/PX4-Autopilot#17440
PX4/PX4-Autopilot#17403

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfuhrer Thanks very much.

It is very clear what the landing behaviour states are for MC, but not for FW. Is it that we don't have any states?

Note, I added back a heading for Landing Detector States, but just for MC.

I'm marking as approved, but lets see what @MaEtUgR says too.

@sfuhrer
Copy link
Contributor Author

sfuhrer commented Jan 9, 2023

It is very clear what the landing behaviour states are for MC, but not for FW. Is it that we don't have any states?

Yes correct, the FW one doesn't have any state beside landed.

Copy link
Member

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfuhrer Thanks a lot for taking the initiative. I didn't even realize this is outdated 😇
Really cool description. I only have two small suggestions for clarity.

sfuhrer and others added 2 commits January 10, 2023 11:11
Co-authored-by: Matthias Grob <maetugr@gmail.com>
Co-authored-by: Matthias Grob <maetugr@gmail.com>
@sfuhrer sfuhrer merged commit a482699 into main Jan 10, 2023
@sfuhrer sfuhrer deleted the pr-land-detector-sync branch January 10, 2023 10:13
hamishwillee added a commit to hamishwillee/PX4-user_guide that referenced this pull request Feb 22, 2023
* land detector docs: sync FW parameters and logic

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>

* sync MC land detection docs with PX4 logic

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>

* move all MC land detector info into same block

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>

* land detector: add small section for VTOL

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>

* Apply suggestions from code review

* Update en/advanced_config/land_detector.md

* fix link to states section

* Update en/advanced_config/land_detector.md

Co-authored-by: Matthias Grob <maetugr@gmail.com>

* Update en/advanced_config/land_detector.md

Co-authored-by: Matthias Grob <maetugr@gmail.com>

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Co-authored-by: Matthias Grob <maetugr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants