-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Land detector docs sync #2233
Land detector docs sync #2233
Conversation
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes correct, the FW one doesn't have any state beside landed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfuhrer Thanks a lot for taking the initiative. I didn't even realize this is outdated 😇
Really cool description. I only have two small suggestions for clarity.
Co-authored-by: Matthias Grob <maetugr@gmail.com>
Co-authored-by: Matthias Grob <maetugr@gmail.com>
* land detector docs: sync FW parameters and logic Signed-off-by: Silvan Fuhrer <silvan@auterion.com> * sync MC land detection docs with PX4 logic Signed-off-by: Silvan Fuhrer <silvan@auterion.com> * move all MC land detector info into same block Signed-off-by: Silvan Fuhrer <silvan@auterion.com> * land detector: add small section for VTOL Signed-off-by: Silvan Fuhrer <silvan@auterion.com> * Apply suggestions from code review * Update en/advanced_config/land_detector.md * fix link to states section * Update en/advanced_config/land_detector.md Co-authored-by: Matthias Grob <maetugr@gmail.com> * Update en/advanced_config/land_detector.md Co-authored-by: Matthias Grob <maetugr@gmail.com> Signed-off-by: Silvan Fuhrer <silvan@auterion.com> Co-authored-by: Hamish Willee <hamishwillee@gmail.com> Co-authored-by: Matthias Grob <maetugr@gmail.com>
Notable PX4 PRs with land detector changes incorporated into the docs hereby:
PX4/PX4-Autopilot#20425
PX4/PX4-Autopilot#17440
PX4/PX4-Autopilot#17403