px4_dev base: add python-numpy and python-toml (bis) #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dagar
px4io/px4-dev-basewas correctly rebuilt with tagjlecoeur.But other images were not built with that tag as they were not changed: they still source
px4io/px4-dev-baseand do not contain numpy and toml.I modified all px4 images to source
px4io/px4-dev-base:pr-jlecoeur, this way I will be able to modify.travis.ymlanddocker_run.shon PX4 side to pass tests on PX4/PX4-Autopilot#8063.While it should work, it's kind of convoluted, I hope there is a better way. The last commit will have to reverted before merging.