Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gazebo_usv_dynamics_plugin.cpp #492

Merged
merged 1 commit into from
May 21, 2020
Merged

Update gazebo_usv_dynamics_plugin.cpp #492

merged 1 commit into from
May 21, 2020

Conversation

xdwgood
Copy link
Contributor

@xdwgood xdwgood commented May 14, 2020

PR from: Institute of Geography, Chinese Academy of Sciences

@Jaeyoung-Lim More than one person has encountered a problem.
See: PX4/PX4-Autopilot#14831 #456 https://discuss.px4.io/t/error-about-gazebo-sitl-building/12019/12
I know this may not be the right way, but doing so is not harmful to most people 😃

Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xdwgood Thanks for the fix, previously this didn't work for me, so I suspect something changed regarding what is distributed as the gazebo dependency.

Since CI passes should be good for merging

@xdwgood
Copy link
Contributor Author

xdwgood commented May 19, 2020

@Jaeyoung-Lim CI error is not caused by this PR, can it be merged? Thank you 😃

@Jaeyoung-Lim Jaeyoung-Lim merged commit ab527bf into PX4:master May 21, 2020
@xdwgood xdwgood deleted the xdwgood-patch-1 branch May 22, 2020 00:24
RyosukeMatsushima pushed a commit to RyosukeMatsushima/PX4-SITL_gazebo that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants