-
Notifications
You must be signed in to change notification settings - Fork 509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look like they should address the issue caused by unnecessary and incorrect application of _hgt_sensor_offset to baro height. We do need to get some test data for the GPS -> baro -> GPS height case. This should be possible in SITL by setting EKF2_HGT_MODE = 1 stopping GPS and then restarting it .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could try to add a test for this. Reproduce the issue in sitl. Convert the ulog to the sensor data format. Replay the data during the test just before the switch to baro. Switch to baro, continue replaying the data for some small amount. And check that the height is closed to the one before the switch.
The same data could then also be used for more extensive change_indication.
…t mode - fixes #14677 - updates ecl with PX4/PX4-ECL#799
I even got a better one here after going in and out of range aid a few times: |
When the primary height source is GPS but the GPS data times out, EKF2 switches to baro and makes a reset. However, the
_hgt_sensor_offset
was not set to 0 and the height reset creates an incorrect jump in the state.partially fixing PX4/PX4-Autopilot#14677