Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

px4fmu driver refactor #8142

Closed
dagar opened this issue Oct 17, 2017 · 3 comments
Closed

px4fmu driver refactor #8142

dagar opened this issue Oct 17, 2017 · 3 comments

Comments

@dagar
Copy link
Member

dagar commented Oct 17, 2017

Notes and ideas for a px4fmu refactor.

Split drivers/px4fmu into the following separate modules

  • px4fmu (PWM output + overall PWM/GPIO configuration)
  • rc_input (runs in work queue at X00Hz) (could eventually be merged with drivers/spektrum_rc, drivers/ocpoc_sbus_rc_in, and likely others)
  • safety_button module (runs in work queue at 10Hz)
  • i2c command (only bus configuration, but could be extended to scan bus, etc)
  • spi command (only a reset currently, but could be extended to scan bus, etc)
  • Anything else that can be deleted or moved to a separate module? GPIO IOCTL configuration? PWM capture?

The remaining px4fmu core should be extended to support multiple instances (#7208).

This should help save some space on platforms that don't use the other pieces. (#7993) @zehortigoza FYI

https://github.com/dagar/Firmware/tree/pr-fmu_split

@iZhangHui @davids5 @rolandash

@dagar dagar added this to the Release v1.8.0 milestone Oct 17, 2017
@dagar dagar self-assigned this Oct 17, 2017
@iZhangHui
Copy link
Contributor

@dagar Great work! Thank you. Your PR makes px4fmu codes more clean, clear and maintenance easier.
At the same, it will reduce firmware size for some flight controllers and ram consumption.
One concern is that ModuleBase doesn't support modules which allow multiple instances.

@dagar
Copy link
Member Author

dagar commented Oct 19, 2017

We can either extend it or make a new version that does. It's something we'll need to do for an improved driver framework either way.

There are still lots of inconsistencies in px4fmu when used as MAIN vs AUX that need to be fixed.

@PX4BuildBot
Copy link
Collaborator

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants