Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary submodules #8089

Closed
dagar opened this issue Oct 8, 2017 · 2 comments
Closed

remove unnecessary submodules #8089

dagar opened this issue Oct 8, 2017 · 2 comments
Assignees

Comments

@dagar
Copy link
Member

dagar commented Oct 8, 2017

Submodules are generally pretty annoying, and we're currently carrying several that can either be replaced by packages or not included at all.

  • gencpp and genmsg (https://github.com/PX4/Firmware/tree/master/msg/tools) are widely available as packages
  • jmavsim and sitl_gazebo are simulation tools that don't share any source dependencies with the Firmware
    • we could have cmake download these and build them on the side when needed
  • look at dropping mavlink/v1.0. The main mavlink module only uses mavlink 2.0 (even for mavlink 1.0 mode), but some other modules (like simulation) still point at mavlink/v1.0
@dagar dagar added this to the Release v1.8.0 milestone Oct 8, 2017
@dagar dagar self-assigned this Oct 8, 2017
@dagar
Copy link
Member Author

dagar commented Oct 16, 2017

Removing gencpp and genmsg here: #8132

@PX4BuildBot
Copy link
Collaborator

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants