Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QML Performance: MissionItemEditor creation expensive #7674

Closed
NaterGator opened this issue Jul 24, 2017 · 1 comment
Closed

QML Performance: MissionItemEditor creation expensive #7674

NaterGator opened this issue Jul 24, 2017 · 1 comment

Comments

@NaterGator
Copy link
Contributor

I've been doing some profiling of master and I am finding that the MissionItemEditor component is particularly expensive for QML to create. This problem becomes apparent when connecting to a vehicle with a survey mission onboard (or downloading a survey mission) where a bunch of mission items are included in the plan.

It obviously isn't critical, just something we should address in a future release. I think a good approach is to either defer the full underlying item editor (the editorLoader accounts for ~55% of creation time) or better yet to have incredibly simple delegates that move a singleton full MissionItemEditor into their component and bind it to their underlying mission item.

@NaterGator
Copy link
Contributor Author

Sigh. Too many windows open, moving this over to qgc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant