[Bug] dshot reverse command broken after release 1.13

[TedObrien]

Describe the bug

Using the dshot reverse and dshot normal to change spin direction of motor no longer works after release 1.13.

To Reproduce

Tested with APD 80F3[X]v2

running v1.14

1. Power on drone and enter mavlink console on QGC
2. command dshot beep1 -m 1 works as expected and a beep is heard
3. command dshot reverse -m 1 does not not produce any sound from the esc/motor like it does in 1.13 and the motor direction remains unchanged.

Expected behavior

When running dshot reverse -m 1 in 1.13, a beep is made and the motor direction changes. dshot save then saves this direction after its powered down.

Screenshot / Media

Issue appears to have been introduced in #19758

Reverting the 2 lines changed in this commit I get the expected behavior in 1.14.

I have only tested this with the APD 80F3[X]v2. It's possible it's hardware specific as the commit was supposed to fix #19756. From my testing, using dshot save makes the direction change persist, counter to the bug report.

EDIT: Tested with a T-motor 4 in 1 esc running bl-heli32

• On main branch dshot reverse command still does not work
• On https://github.com/TedObrien/PX4-Autopilot/tree/old-dshot-direction-command where direction change commands were reverted to pre Corrected DShot motor spin direction command - fixes #19756 #19758 the dshot reverse and dshot save commands result in a persistant change in motor direction.

Let me know if I should make a PR. Thanks

Flight Log

NA

Software Version

v1.14 and above

Flight controller

holybro v6x

Vehicle type

Multicopter

How are the different components wired up (including port information)

No response

Additional context

No response