Fixes mavlink id starting at 2 for sitl_multiple_run #23529
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This is undoing the changes from #21183
@beniaminopozzan Can you chime in here?
|
So, the idea behind having the multi instance script starting the vehicles with MAV_ID = 2 instead of one was to separate the logic between single and multi-vehicle in sim w.r.t. the uxrcedds client:
It is adopted here: PX4-Autopilot/ROMFS/px4fmu_common/init.d-posix/rcS Lines 286 to 291 in 64056fc And documented here: https://docs.px4.io/main/en/ros2/multi_vehicle.html#principle-of-operation I am not against reverting this as long as it remains consistent with the documentation please. FYI @av-jeroen you missed the second possible call of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Fixes #23480
Solution
Changelog Entry
For release notes:
Alternatives
We could also leave it as is. mav_sys_id=2 is not perse wrong, just unexpected.
Test coverage
not added
Context
not added