Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigator bug: "Takeoff to x meters above home." after mission ended #14011

Closed
bkueng opened this issue Jan 22, 2020 · 1 comment · Fixed by #14020
Closed

navigator bug: "Takeoff to x meters above home." after mission ended #14011

bkueng opened this issue Jan 22, 2020 · 1 comment · Fixed by #14020
Assignees
Labels

Comments

@bkueng
Copy link
Member

bkueng commented Jan 22, 2020

When navigator executes a mission with a landing waypoint, after the mission ends, QGC shows "Takeoff to x meters above home.".
Reproducible 100% in SITL.

To Reproduce
Steps to reproduce the behavior:

  1. simple mission with landing waypoint at the end
  2. run the mission and wait until landed and disarmed

The problem is that navigator resets the mission after disarming (need_to_reset_mission()), and then already sets the first mission item again (set_mission_items()), which leads to a user message. We can defer calling set_mission_items() until we're armed again, but then mc_pos_control goes into failsafe with a warning (which I don't think it should, as it's disarmed) and I want to avoid unnecessary complex logic.

It's not clear to me why navigator does not just switch to land mode, as it does for RTL.
RTL does not have that issue because of the mode switch.

@dagar
Copy link
Member

dagar commented Jan 22, 2020

@RomanBapst any input here (given you've just been through this logic)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants