Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixedwing position controller not able follow position setpoints in offboard mode #12517

Closed
Jaeyoung-Lim opened this issue Jul 18, 2019 · 0 comments

Comments

@Jaeyoung-Lim
Copy link
Member

Jaeyoung-Lim commented Jul 18, 2019

Describe the bug
When streaming position setpoints to the fixed wing vehicle, it can enter offboard mode as the setpoint is sreamed. However, rather than following the setpoints (usually defined in local coordinates) it simply flies straight.

This seems to be because the fixed wing position controller blindly reads from the setpoints in global coordinates from the position_setpoint_triplets.

https://github.com/PX4/Firmware/blob/master/src/modules/fw_pos_control_l1/FixedwingPositionControl.cpp#L854-L855

To Reproduce

  1. Run SITL and start mission while streaming position_setpoints through mavros with setpoint_raw messages to takeoff and loiter
  2. After takeoff, switch vehicle to offboard mode

Expected behavior
When given a position setpoint, the desired behavior is to use it as a reference for the L1 position controller.

Log Files and Screenshots
https://review.px4.io/plot_app?log=f6204199-f876-4253-8d12-cb454c1e816b

As can be seen in the picture below, once the vehicle is in offboard mode, the vehicle simply flies straight.
Screenshot from 2019-07-19 00-59-14

Additional context
Attitude setpoints for offboard mode in fixed wing is currently working. However, to use this a l1 like path tracking controller needs to be implemented on the companion side to make it usable. Being able to stream position setpoints to a fixed wing drone would greatly simplify the interface for robotic applications in fixed wing

@Jaeyoung-Lim Jaeyoung-Lim changed the title Fixedwing position controller can't follow position setpoint in offboard mode Fixedwing position controller not able follow position setpoints in offboard mode Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants