Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the wind static barometric pressure correction #11235

Closed
int32cn opened this issue Jan 18, 2019 · 4 comments · Fixed by #12332
Closed

the wind static barometric pressure correction #11235

int32cn opened this issue Jan 18, 2019 · 4 comments · Fixed by #12332
Labels

Comments

@int32cn
Copy link

int32cn commented Jan 18, 2019

At EFK2_main.cpp run function, the wind static barometric pressure correction is calculated as following:

const float pstatic_err = 0.5f * airdata.rho *
(K_pstatic_coef_x * x_v2) + (_K_pstatic_coef_y.get() * y_v2) + (_K_pstatic_coef_z.get() * z_v2);

And according the air static barometric pressure formula,P = 0.5 * ro * V ^2;
So I 'm wondering here maybe missing a brace, the code above should be as the following:
const float pstatic_err = 0.5f * airdata.rho *
( (K_pstatic_coef_x * x_v2) + (_K_pstatic_coef_y.get() * y_v2) + (_K_pstatic_coef_z.get() * z_v2));

@stale
Copy link

stale bot commented Jun 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@CarlOlsson
Copy link
Contributor

This is still an issue.
Pinging @RomanBapst just so it does not get forgotten

@stale stale bot removed the Admin: Wont fix label Jun 25, 2019
@RomanBapst
Copy link
Contributor

@CarlOlsson thanks for mentioning this, I will fix it today.

@RomanBapst
Copy link
Contributor

@int32cn Thanks for raising this!

@dagar dagar added the bug label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants