Refactor: replace BlockParam's with the new Param class #9115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, and thanks for fixing my pwm_out_sim documentation. |
Also change naming convention: add _ prefix to class attributes
GCC error: error: 'memcpy' was not declared in this scope
bkueng
force-pushed
the
block_param_refactoring_continued
branch
from
29de0cc to
288a492
Compare
|
Rebased & fixed a minor conflict, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces all BlockParam uses with the new Param class, except in
controlliband the MC position controller - I'll coordinate with #8933 to do that.