libtunes improvements #9096
Merged
libtunes improvements #9096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the expanction of the ERROR macro inside the TuneID enum
potaito
force-pushed
the
pr-libtunes-improvements
branch
from
23b4e1a to
7e6e065
Compare
bkueng
previously approved these changes
Mar 19, 2018
There was a problem hiding this comment.
Reviewed & tested on fmu-v5, tunes still work.
While at it, can you please remove the duplicated startup tune in commander (line https://github.com/PX4/Firmware/blob/master/src/modules/commander/commander.cpp#L1532 and https://github.com/PX4/Firmware/blob/master/src/modules/commander/commander.cpp#L1538) - the startup tone is already in the ROMFS.
Addressing review comments in PR #9096
|
@bkueng Thanks for the review!
Good point, that also caused some problems for me in the past where the tune playback was chopped up because of the duplicate. I removed it in the new commit if you want to give it another test :) Edit: argh you were faster 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few small baby steps towards improving libtunes:
src/lib/tunes/tune_definition.h. This might facilitate custom implementations with different tune IDs for branding PX4.src/drivers/drv_tone_alarm.hsrc/lib/tunes/tunes.cppsrc/systemcmds/tests/test_hrt.cI don't currently have px4 hardware with buzzers at hand. Someone please test before merging!
@simonegu FYI