Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKF2 remove FW_ARSP_MODE check #8995

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

dagar
Copy link
Member

@dagar dagar commented Mar 2, 2018

This is a FW controller configuration parameter, and we already have a mechanism to disable airspeed fusion in EKF2, or to disable the airspeed sensor entirely.

As an example of why this isn't quite right, here are the parameters for a regular multicopter.

image

@dagar dagar requested review from priseborough and CarlOlsson March 2, 2018 06:32
@LorenzMeier
Copy link
Member

This looks like it will potentially break existing setups - what happens if someone who has configured this upgrades?

@dagar
Copy link
Member Author

dagar commented Mar 2, 2018

It would have to be someone that has an active working airspeed sensor, set the FW controllers to airspeed disabled mode, didn't set the circuit breaker, and then set the EKF2 airspeed fusion threshold. Then it's a question of how the EKF would handle these actual airspeed readings.

EKF2_ARSP_THR - airspeed fusion threshold (defaults to 0 for off)
CBRK_AIRSPD_CHK - disable airspeed sensor check (also skips differential pressure startup in init)
FW_ARSP_MODE - tells the FW controllers not to use the airspeed sensor

It seems pretty clear to me that the setting for the FW controllers shouldn't be used within the estimator configuration, and the estimator already has a mechanism for ignoring airspeed. It's also possible that someone might want to use airspeed fusion in the estimator, but ignore airspeed in the controllers.

@LorenzMeier LorenzMeier merged commit 4c4f990 into PX4:master Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants