Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcc7 warnings #8417

Merged
merged 2 commits into from
Dec 6, 2017
Merged

Fix gcc7 warnings #8417

merged 2 commits into from
Dec 6, 2017

Conversation

jlecoeur
Copy link
Contributor

@jlecoeur jlecoeur commented Dec 5, 2017

Build is broken on gcc7, because of the warnings -Wimplicit-fallthrough and -Wnonnull-compare.
This PR:

  • fixes the gcc7-only warnings in PX4 codebase
  • silences the gcc7-only warnings in NuttX codebase. As these warnings are not checked by NuttX developpers, it will be difficult to prevent them from reappearing. Other suggestions are welcome!

In order to test both posix and nuttx target with gcc7, I created an ArchLinux docker image: PX4/PX4-containers#84

@dagar

@dagar
Copy link
Member

dagar commented Dec 5, 2017

Thanks, once the new CI system settles I was planning to add posix_sitl_default builds for a wide range of distros and versions to stay on top of this kind of thing.

  • ubuntu last lts - present (default gcc, cmake, etc)
  • ubuntu lts with default clang
  • ubuntu latest with latest clang
  • fedora current
  • arch
  • any others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants