Fixed version firmware type #8250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the version tag to number and version tag to vendor version number to return dev version in case of any local modifications or in case there's a dash before firmware type in tags that support vendor version.
|
Thanks! I've been meaning to look at this. |
|
The circleci failure is real (trivial style change), jenkins sitl01 is broken globally. |
|
@dagar Thanks for response! Passed the circleci check |
|
@dagar good to merge? |
darioxz
suggested changes
Nov 9, 2017
There was a problem hiding this comment.
@garfieldG, thanks for the improvement. Could you please add new test cases to the corresponding unit test?
Please have a look at test_versioning.cpp.
Local modification cases and a dash before firmware type in tags that support vendor version cases.
|
@darioxz Added new test cases as requested. |
darioxz
approved these changes
Nov 9, 2017
|
Looks good. I'm going to do some quick testing and get this in for v1.7.0. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the version tag to number and version tag to vendor version number to return dev version in case of any local modifications or in case there's a dash before firmware type in tags that support vendor version.