-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
navigator: check distances between waypoints #8146
Conversation
Instead of just checking whether the first waypoint is too far away from home it makes sense to also check between waypoints. This can prevent - flyaways due to user errors, or - catch the corner case where a takeoff waypoint is added to a mission and therefore the first waypoint is not too far away, however, the subsequent waypoints are still too far away.
Sounds like a good addition. While we're on the subject, what do you think of the distance to first waypoint check? The majority of our existing feasibility checks could happen even before you have GPS or a valid home. So if we handle the distance to first waypoint check at a different level we could be a lot more restrictive and prevent navigator from taking the mission at all if it's not feasible. The current situation where navigator has the updated mission even if it's not feasible can be dangerous. |
But it is still safe because it won't do the mission later even if you can upload it. I think the advantage of the current flow is that you can load the mission before going to the field. |
I want both the ability to plan the mission before going to the field (when possible), and the separation of navigator mission not even able to touch an infeasible mission. By not safe I mean for a plane that needs a planned mission landing to not hit trees or a building. |
I see. So we need library calls for the mission checks that we can use in e.g. mavlink where the mission arrives but also later in navigator. |
@julianoes this might make sense for multirotors but for FW it is way too narrow a default. Any ideas on how to solve this? Maybe disable by default and set it separately in MC FW and VTOL rc defaults script? |
@sanderux I didn't think of that. I was assuming most people can only fly line of sight, so a radius of 500m anyway 😄. I think it makes sense to change the param once you are actually doing a longer mission (and really know what you're doing), or change the param for the vehicle, so you could add it into the DeltaQuad startup script. |
It is making it hard for me to manage vehicles already in service when they upgrade. |
I guess so. Otherwise you can hard-code it for DeltaQuad in:
Or if you only want it to be changed on auto-config, then add it in there. |
For the DeltaQuad i can fix it (its still manageable now) but im also concerned for other vtol/fw users |
I still think the default values make sense for the general case because I think we should err on the side of caution and trying to prevent fly-aways. |
Instead of just checking whether the first waypoint is too far away from home it makes sense to also check between waypoints.
This can prevent
and therefore the first waypoint is not too far away, however, the
subsequent waypoints are still too far away.
Tested in SITL using DroneCore.