Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When switching to land in VTOL, update land target during back trans #8119

Merged
merged 2 commits into from
Oct 15, 2017

Conversation

sanderux
Copy link
Member

Currently, when switching to LAND mode on a vtol, it will perform a back transition and landing simultaneously. This prevents the vehicle trying to navigate back to where the back transition started during landing as it might result in a landing while tilted.

@sanderux
Copy link
Member Author

@PX4TestFlights Due to weather conditions i am unable to test this safely.
Could you test fly on a vtol:
Param NAV_FORCE_VT: enabled (this is default)
Fly in any mode and switch to LAND. It should do a back transition and land at the location it came out of the backtransition. Before this PR it will attempt to navigate back to the place where the LAND command was initiated while descending.

@dagar
Copy link
Member

dagar commented Oct 12, 2017

We need to be careful here and make sure the throttle and speed is set in the position setpoint.

@dagar
Copy link
Member

dagar commented Oct 12, 2017

This is also a problem for regular multicopters if you flip into LAND mode with any velocity.

Something like the simple state machine in other nav states like RTL would work well. First come to a full stop (including back transition if a VTOL), then create the land waypoint below.

Similar to #8101.

@Stifael FYI

@Stifael
Copy link
Contributor

Stifael commented Oct 12, 2017

I think it is similar to #8057

@sanderux
Copy link
Member Author

Should we get this in after testing and work on a better state machine for 1.8?

@sanderux sanderux added this to the Release v1.7.0 milestone Oct 15, 2017
@LorenzMeier LorenzMeier merged commit fd6f219 into master Oct 15, 2017
@LorenzMeier LorenzMeier deleted the pr-vtol_land_transition_update branch October 15, 2017 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants