Make FTP more robust #7979
Merged
Make FTP more robust #7979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error definitions already existed in QGC
|
Is the mavlink_ftp_test working now? |
|
It should. At least CI failed because of that, and when I ran the tests locally, the last commit fixed it. |
|
I was thinking of this - https://github.com/PX4/Firmware/blob/master/src/modules/mavlink/mavlink_tests/mavlink_ftp_test.cpp#L936 I could restore the test data generation pretty quickly, but I'm not sure about the others. |
|
Ah I did not see these. If it's not too much effort, it's worth enabling them. |
|
Merging, since the QGC PR got merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make FTP robust against any kind of packet drops. On the vehicle side, this mostly means to keep a copy of the last sent response, most of the logic is in a QGC PR.