Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use default stack size of 2048, fixes stack check failure #13802

Merged
merged 1 commit into from
Dec 29, 2019

Conversation

modaltb
Copy link
Contributor

@modaltb modaltb commented Dec 28, 2019

Describe problem solved by this pull request
Fixes stack size error found using stackcheck build during debug session with David S.

Describe your solution
Use default module stack size of 2048 specified by px4_add_module.cmake

@modaltb
Copy link
Contributor Author

modaltb commented Dec 28, 2019

Any idea how to do a PR against a tag? I'd like to get this into 'tags/v1.11.0-beta1' if possible.

@dagar dagar merged commit 9b707ee into PX4:master Dec 29, 2019
@dagar
Copy link
Member

dagar commented Dec 29, 2019

Any idea how to do a PR against a tag? I'd like to get this into 'tags/v1.11.0-beta1' if possible.

You can't, but we could drop the next tag. Does everything else in master check out from your perspective?

@modaltb
Copy link
Contributor Author

modaltb commented Dec 29, 2019

Is it cool if I wrap up some testing tomorrow and let you know?

@dagar
Copy link
Member

dagar commented Dec 29, 2019

Is it cool if I wrap up some testing tomorrow and let you know?

No rush, enjoy the holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants