Clarify Documentation of THR_MDL_FAC #13129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation of the thrust model parameter `THR_MDL_FAC` did not mention both thrust and "PWM" being relative values. Also the use of the term PWM could be misleading, since the model is applicable to CAN ESCs as well. This commit rephrases the user documentation string and a few source code comments, but no logic changes are made. Closes PX4#13105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation of the thrust model parameter
THR_MDL_FACdid not mention both thrust and "PWM" being relative values. Also the use of the term PWM could be misleading, since the model is applicable to CAN ESCs as well.PWM was replaced with motor control signal, and the description text for the parameter list (or QGC parameter description) was changed to make the model more clear.
Could close #13105