-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Takeoff - allow publishing NAN longitude and latitude #12936
Conversation
A NAN is interpreted in the FlightTaskAuto as a non-valid global coordinate and sets a local position. If a zero is sent instead, the global coordinate is recognized as valid and will be executed. This is a problem when the global position is gained for the first time after takeoff and that a valid global reference did not exist before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me this seems a major bugfix, since if we don't set them when the rep->current.lon
is NaN, they remain 0.0, which is much more misleading/incorrect.
@PX4/testflights Could you test that PR please?
|
Tested on CUAV+ V5: Mission Plan Mode (Automated): Good. - Procedure
Log: Tested on PixRacer V4: Mission Plan Mode (Automated): Good. - Procedure
Log: |
Tested on Pixhawk 4 f-450 Modes Tested Procedure Notes: Log: |
A NAN is interpreted in the FlightTaskAuto as a non-valid global coordinate and sets a local position.
If a zero is sent instead, the global coordinate is recognized as valid and will be executed.
This is a problem when the global position is gained for the first time after takeoff and that a valid global reference did not exist before
fixes #12919
To reproduce:
ekf2 stop
,gps stop
,ekf2 start
)gps start ...
)