Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed rover CI test #12491

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Removed rover CI test #12491

merged 1 commit into from
Jul 17, 2019

Conversation

AmeliaEScott
Copy link
Contributor

Describe problem solved by the proposed pull request
The Rover CI test is failing seemingly at random, due to a timeout between the actuator_controls_0 topic and Gazebo. See this build and Issue #12490

The PR of the linked build does not change anything that should cause this build failure, so future PRs may also fail this test for no apparent reason. Therefore, this PR disables that test entirely so that it can be fixed. As long as it is broken, other PRs will need to be force-merged while failing the SITL tests.

Describe your preferred solution
Commented out the rover_mission_1 SITL test in the Jenkins files.

Describe possible alternatives
This test will need to be properly fixed in the future. This is only a temporary bandage to prevent build failures.

@AmeliaEScott AmeliaEScott added bug Rover 🚙 Rovers and other UGV labels Jul 16, 2019
@AmeliaEScott AmeliaEScott self-assigned this Jul 16, 2019
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bresch bresch merged commit 51d4239 into PX4:master Jul 17, 2019
@AmeliaEScott AmeliaEScott deleted the pr-temporary-ci-fix branch July 19, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Rover 🚙 Rovers and other UGV
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants