jenkins: pub_test needs to start px4 in daemon mode #12483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
approved these changes
Jul 16, 2019
| <include file="$(find px4)/launch/mavros_posix_sitl.launch"> | ||
| <arg name="gui" value="false"/> | ||
| <arg name="interactive" value="false"/> | ||
| <arg name="verbose" value="true"/> |
There was a problem hiding this comment.
I'm not sure if we want the verbose gazebo output?
There was a problem hiding this comment.
We do. It's useful for sitl_gazebo issues. We have this for all other CI SITL testing.
|
That error is mavros related I believe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #12475. I remember this occurring in the past with our other tests. Jenkinsfile-SITL_tests are all run in daemon mode.
It looks like Jenkins does something weird with the interactive shell that shuts down px4.