Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ll40ls: Fix LIDAR-Lite v3 initialization #12453

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

dvornikov-aa
Copy link
Contributor

The current initialisation code works only if every UID byte contains a non-zero value. According to the manual UNIT_ID is a unique value without any restrictions.

@julianoes julianoes requested a review from bkueng July 10, 2019 12:41
@julianoes julianoes added the Sensors All the sensors! label Jul 10, 2019
@dagar
Copy link
Member

dagar commented Jul 10, 2019

@mcsauder do you have one of these to test?

@mcsauder
Copy link
Contributor

Hi @dagar , I do. No errors on startup and bench tests look fine.
image

Bench test of this PR:
image

Bench test of PX4:master:
image

@mcsauder
Copy link
Contributor

Here is a capture at boot adding in printout to that logic block for your convenience, (succeeds on bus 3):
image

Behavior is identical to PX4:master when the same printout is added to master:
image

@bkueng bkueng requested a review from DanielePettenuzzo July 10, 2019 15:35
@mcsauder mcsauder self-assigned this Jul 12, 2019
@DanielePettenuzzo
Copy link
Contributor

@dvornikov-aa Did you find a sensor with id equal to 0? Anyway looks good although currently the lidar lite v3 HP seems to be broken so anyway things might slightly change in the probe in the near future. @cmic0 and I are looking for a proper fix to support all the lidar lites

@dvornikov-aa
Copy link
Contributor Author

@DanielePettenuzzo It's not just about one UID. We lose all UIDs where one of the octets (!) is zero.

By the way, I do have a sensor with UID = 0. I've checked UNIT_ID_HIGH and UNIT_ID_LOW using Pixhawk 2 and Raspberry Pi.

@dagar dagar merged commit e9397ee into PX4:master Jul 31, 2019
@dvornikov-aa dvornikov-aa deleted the pr-ll40ls_init branch January 10, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sensors All the sensors!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants