Refactor the LeddarOne driver to standardize against other distance sensor drivers. #11858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsauder
force-pushed
the
leddar_one_work
branch
3 times, most recently
from
87479ab to
93bcb8e
Compare
mcsauder
force-pushed
the
leddar_one_work
branch
2 times, most recently
from
0c90ba8 to
c5b7b76
Compare
mcsauder
force-pushed
the
leddar_one_work
branch
2 times, most recently
from
c242c9d to
0901c3f
Compare
mcsauder
force-pushed
the
leddar_one_work
branch
2 times, most recently
from
34a385d to
710a6e7
Compare
mcsauder
force-pushed
the
leddar_one_work
branch
2 times, most recently
from
c867dce to
375c446
Compare
mcsauder
force-pushed
the
leddar_one_work
branch
2 times, most recently
from
a4b459c to
2d85d0f
Compare
mcsauder
force-pushed
the
leddar_one_work
branch
3 times, most recently
from
64c0af6 to
132bbcd
Compare
…mploy uniform initialization style. Copy/paste help() and main() methods to the bottom of the file to match convention with other distance sensor drivers.
…thods that were global and to standardize the implementation against most of the other distance sensor drivers.
mcsauder
force-pushed
the
leddar_one_work
branch
from
132bbcd to
5f05bcd
Compare
…rOne::read() method.
|
Bench tests compare well with PX4:master, no perceptable differences in data: PX4:master: This PR: |
… measure() method to untangle the previous logic implementation.
mcsauder
changed the title
dagar
approved these changes
Jun 29, 2019
|
Thank you for your review @dagar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
This PR refactors the LeddarOne distance sensor driver to better match other distance sensor driver implementations to allow for a future inheritance architecture.
This PR:
measure()methodTest data / coverage
This PR has been bench tested, see comments/plots below. All bench tests show identical behavior to current PX4:master branch.
Flight test data will be posted when available.
Additional context
See #9279, #11853, #11857
Please let me know if you have any questions on this PR. Thanks!
-Mark