Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmu handle sensor_reset, peripheral_reset, i2c in board #11347

Closed
wants to merge 1 commit into from

Conversation

dagar
Copy link
Member

@dagar dagar commented Jan 30, 2019

The fmu commands sensor_reset, peripheral_reset, i2c can all be handled better by the board itself.

I will test this on a range of good and questionable fmu-v4 units.

@LorenzMeier
Copy link
Member

@dagar While I appreciate the cleanup, the original reason for these commands to be present was to also induce errors / resets on the bench and see if the hardware recovers. We lose that capability with this PR.

@dagar
Copy link
Member Author

dagar commented Jan 30, 2019

We can have a simple command line for each that's actually used.

@dagar dagar force-pushed the pr-board_peripheral_reset branch from d854010 to 0422467 Compare January 30, 2019 15:18
@@ -399,5 +399,15 @@ __EXPORT int board_app_initialize(uintptr_t arg)

#endif

/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are not doing the GPIO init and this just masks the root issues.

As a side note are we ok delaying Boot? We can Break the reset into 2 pieces, it is all GPIO manipulation. Make the arch init set things up correctly. Then use the delay 3+ ms. from the aching to the app init. Then set up a call back to finish the job.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I figured this would prompt the discussion to check for what's actually needed.

 - create new standalone board control command
@stale
Copy link

stale bot commented Oct 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Oct 13, 2019
@dagar dagar added this to the Release v1.12.0 milestone May 6, 2020
@stale stale bot removed the stale label May 6, 2020
@stale
Copy link

stale bot commented Aug 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants