Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fw_pos_control_l1 skip wind > max airspeed logic if airspeed invalid #11141

Merged
merged 1 commit into from
Jan 12, 2019
Merged

fw_pos_control_l1 skip wind > max airspeed logic if airspeed invalid #11141

merged 1 commit into from
Jan 12, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Jan 3, 2019 •
edited by AuterionWrikeBot
Loading

  • cleanup airspeed validity check logic

@dagar dagar requested a review from RomanBapst January 3, 2019 19:06
@Antiheavy
Copy link
Contributor

Antiheavy commented Jan 10, 2019 •
edited
Loading

Here is a VERY high wind test flight log that includes this PR. This PR is mixed in with some other changes (airspeed failsafe), but the testing is probably still valid.
https://review.px4.io/plot_app?log=d9a42e33-32b2-4530-ad71-bc9d917465f6

Lots of high airspeed, low groundspeed flight conditions, including backwards flight:
image

Lots of airspeed checkbits (caused by the extreme winds):
image

@LorenzMeier
Copy link
Member

Reviewed line-by-line, merging.

@LorenzMeier LorenzMeier merged commit 45d7165 into master Jan 12, 2019
@LorenzMeier LorenzMeier deleted the pr-fw_pos_ctrl_airspeed_valid branch January 12, 2019 13:19
@weekly-digest weekly-digest bot mentioned this pull request Jan 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorenzMeier LorenzMeier LorenzMeier approved these changes

@RomanBapst RomanBapst Awaiting requested review from RomanBapst

Assignees
No one assigned
Labels
Fixed Wing 🛩️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dagar @Antiheavy @LorenzMeier