Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission yawing timeout in mission not working #12626

Closed
sfuhrer opened this issue Aug 5, 2019 · 1 comment
Closed

Mission yawing timeout in mission not working #12626

sfuhrer opened this issue Aug 5, 2019 · 1 comment
Assignees
Labels
bug Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing!

Comments

@sfuhrer
Copy link
Contributor

sfuhrer commented Aug 5, 2019

Describe the bug
When MIS_YAW_TMT is set to something >0, the expected behavior is that for a waypoint with enforced heading, the vehicle tries to align with the yaw setpoint for the time set in MIS_YAW_TMT, and otherwise aborts the mission. This feature is necessary for VTOLs during front transition, as we then want a heading enforced (not transitioning in arbitrary direction), but yaw authority on a VTOL is usually limited in windy conditions.
If the current mission is aborted, the user should then plan a new one where the transition points into the wind.

To Reproduce
Set MIS_YAW_TMT to something !=0.
Plan mission with (seperate) VTOL transition (not VTOL takeoff, as then heading is not enforced).
(In sitl, when MIS_YAW_TMT is set to 1 and the vehicle has to turn eg 90°, it should abort as it doesn't manage that in 1s)

Expected behavior
Abort mission when the vehicle can't align with yaw setpoint at transition point within MIS_YAW_TMT.

Additional context
I think that the problem is that the counter responsible for measuring the yawing time at the transition wp gets reset all the time, and thus does never reach above MIS_YAW_TMT. It gets reset because _waypoint_position_reached is reset to false after every time is_mission_item_reached() is executed (mission_block.cpp). This seems to have been introduced with #4992

@sfuhrer
Copy link
Contributor Author

sfuhrer commented Oct 1, 2019

fixed with #12630

@sfuhrer sfuhrer closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing!
Projects
None yet
Development

No branches or pull requests

1 participant