Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters being used after logging/arming #12432

Closed
garfieldG opened this issue Jul 8, 2019 · 6 comments
Closed

Parameters being used after logging/arming #12432

garfieldG opened this issue Jul 8, 2019 · 6 comments

Comments

@garfieldG
Copy link
Contributor

The following parameters are being used only after arming :
COM_ARM_EKF_AB
COM_ARM_EKF_GB
COM_ARM_EKF_HGT
COM_ARM_EKF_POS
COM_ARM_EKF_VEL
COM_ARM_EKF_YAW

same goes to SDLOG_UUID param, being used only after log has started.

May cause issues if you try to go over your parameters and then not even being aware there are more parameters not shown just because you didn't arm/started new log.

@julianoes
Copy link
Contributor

FYI @dagar

@dagar dagar added the bug label Jul 8, 2019
@dagar
Copy link
Member

dagar commented Jul 8, 2019

The COM_ARM_EKF* parameters are read slightly later in commander preflight check, but still only before arming. SDLOG_UUID is found and used at log creation.

@garfieldG have you verified this in current master or v1.9.0? As of f851978#diff-06bd9bf93c4b14e72b5518a112c266b7 I think it should be resolved for the commander parameters.

@garfieldG
Copy link
Contributor Author

@dagar just verified it with v1.9.2 and you're right regarding COM_ARM_EKF* params, they do appear.

@julianoes
Copy link
Contributor

@garfieldG so this is resolved?

@garfieldG
Copy link
Contributor Author

@julianoes as to COM_ARM_EKF* params params yes.
SDLOG_UUID founded only in log creation.

@stale
Copy link

stale bot commented Oct 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Oct 16, 2019
@bresch bresch closed this as completed Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants